Ben Scott

Results 68 comments of Ben Scott

I removed the `privateDNSZone` parameters from the sample yaml file, and updated the annotations to describe the requirements a bit better.

@jianli-wei hello Jianli, can you let me know if these last round of changes look good to you? Thank you

> @bscott-rh this functionality will be tech preview for 4.12. Can we add some sort of messaging to that effect? @patrickdillon Thanks for the reminder - I've added our tech...

> @jianli-wei @bscott-rh `1. If crednetialsMode can also be "Manual", after creating install-config.yaml and before create cluster, additional steps on creating manifests and then the credentials would be needed.` >...

@jianli-wei I've updated the PR with your suggestions, thanks. PTAL and I will update the credentials mode annotation once I have Patrick's feedback.

/label peer-review-needed Dearest reviewers, this PR has already gone through one round of peer review, but I made several changes through QE/SME review. Please take a second look before I...

@jmanthei Hi Jessi, what versions should this PR apply to?