openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

[enterprise-4.12] OSDOCS-4137: add SE RN entry

Open jldohmann opened this issue 2 years ago • 1 comments

Version(s): 4.12

Issue: https://issues.redhat.com/browse/OSDOCS-4137

Link to docs preview: http://file.rdu.redhat.com/jdohmann/OSDOCS-4118-RN/release_notes/ocp-4-12-release-notes.html#ocp-4-12-secure-execution-z-linux-one

QE review:

  • [ ] QE has approved this change.

Additional information:

jldohmann avatar Oct 14 '22 21:10 jldohmann

🤖 Updated build preview is available at: https://51732--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/5821

ocpdocs-previewbot avatar Oct 14 '22 21:10 ocpdocs-previewbot

@SNiemann15 Do you think the RN should have an entry for this in the IBM Z and LinuxONE section too? I realize the content may be duplicated, but I imagine some people jump straight to certain sections that are relevant to them.

jldohmann avatar Oct 26 '22 21:10 jldohmann

d38ef56..38fa000 implement Silke feedback 38fa000..c70ccc6d14 add xref to feature doc c70ccc6d14..29b9041523 implement QE feedback 29b9041523..80ef8fe8c7 implement peer review feedback pt1 80ef8fe8c7..62f7868756 implement peer review feedback pt2 62f7868756..4241ac8076 rebase 4241ac8076..61400bf80e fix xref

jldohmann avatar Oct 26 '22 21:10 jldohmann

@jldohmann Thanks for bringing that up. We will surely add SE info to the IBM Z and LinuxONE section too. I need to discuss with @holgwolf if we only want to add SE to the list of supported features or add more info.

SNiemann15 avatar Oct 27 '22 11:10 SNiemann15

@jldohmann I totally forgot to give you the PR for the IBM SE installation: https://github.com/openshift/openshift-docs/pull/52661

SNiemann15 avatar Dec 15 '22 13:12 SNiemann15

Thank you @SNiemann15 ! Were you and @holgwolf able to sync about what to add to the IBM Z and LinuxONE section of the RN? I'm happy to add it to this PR if so!

jldohmann avatar Dec 16 '22 19:12 jldohmann

@jldohmann Thanks for the offer we have it included in this PR: https://github.com/openshift/openshift-docs/pull/53464

SNiemann15 avatar Dec 19 '22 09:12 SNiemann15

@holgwolf thank you for the feedback, I've made some updates. Could you PTAL for the lgtm? @mike-nguyen could you also PTAL for QE ack? Thank you!

jldohmann avatar Dec 19 '22 15:12 jldohmann

/label peer-review-in-progress

bscott-rh avatar Dec 19 '22 15:12 bscott-rh

/lgtm

holgwolf avatar Dec 21 '22 12:12 holgwolf

@holgwolf: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Dec 21 '22 12:12 openshift-ci[bot]