openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

OCPBUGS-15219 Creating a Custom Ingress Controller

Open jmanthei opened this issue 2 years ago • 13 comments

Version(s):

Issue: https://issues.redhat.com/browse/OCPBUGS-15219

Link to docs preview: https://66188--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/ingress-operator#nw-create-custom-ingress-controller_configuring-ingress

QE review:

  • [ ] QE has approved this change.

Additional information:

jmanthei avatar Oct 12 '23 20:10 jmanthei

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Apr 09 '24 09:04 openshift-bot

@Miciah please review

jmanthei avatar Apr 15 '24 15:04 jmanthei

🤖 Fri Jun 07 18:42:21 - Prow CI generated the docs preview:

https://66188--ocpdocs-pr.netlify.app/openshift-dedicated/latest/networking/ingress-operator.html https://66188--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/ingress-operator.html https://66188--ocpdocs-pr.netlify.app/openshift-rosa/latest/networking/ingress-operator.html

ocpdocs-previewbot avatar Apr 15 '24 15:04 ocpdocs-previewbot

@Miciah are you QE for this or should I outreach Shudi Li?

jmanthei avatar Apr 23 '24 16:04 jmanthei

/label peer-review-needed

jmanthei avatar Apr 23 '24 16:04 jmanthei

/remove-label lifecycle-stale

jmanthei avatar May 01 '24 14:05 jmanthei

@jmanthei: The label(s) /remove-label lifecycle-stale cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, peer-review-done, peer-review-in-progress, peer-review-needed, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, staff-eng-approved, telco. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/remove-label lifecycle-stale

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar May 01 '24 14:05 openshift-ci[bot]

/remove-label lifecycle/stale

jmanthei avatar May 01 '24 14:05 jmanthei

@jmanthei: The label(s) /remove-label lifecycle/stale cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, peer-review-done, peer-review-in-progress, peer-review-needed, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, staff-eng-approved, telco. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/remove-label lifecycle/stale

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar May 01 '24 14:05 openshift-ci[bot]

/remove-lifecycle stale

jmanthei avatar May 02 '24 15:05 jmanthei

@melvinjoseph86 QE check please

jmanthei avatar May 10 '24 18:05 jmanthei

/label peer-review-needed

jmanthei avatar May 10 '24 18:05 jmanthei

@jmanthei: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jun 07 '24 18:06 openshift-ci[bot]

/label merge-review-needed

Thanks to everyone!

jmanthei avatar Jun 07 '24 19:06 jmanthei

@jmanthei Hi Jessi, what versions should this PR apply to?

bscott-rh avatar Jun 07 '24 20:06 bscott-rh

@bscott-rh 4.12+, thank you!

jmanthei avatar Jun 10 '24 14:06 jmanthei

Merge review LGTM

bscott-rh avatar Jun 10 '24 14:06 bscott-rh

/cherrypick enterprise-4.12

bscott-rh avatar Jun 10 '24 14:06 bscott-rh

/cherrypick enterprise-4.13

bscott-rh avatar Jun 10 '24 14:06 bscott-rh

/cherrypick enterprise-4.14

bscott-rh avatar Jun 10 '24 14:06 bscott-rh

/cherrypick enterprise-4.15

bscott-rh avatar Jun 10 '24 14:06 bscott-rh

/cherrypick enterprise-4.16

bscott-rh avatar Jun 10 '24 14:06 bscott-rh

@bscott-rh: #66188 failed to apply on top of branch "enterprise-4.12":

Applying: OCPBUGS-15219 Creating a Custom Ingress Controller
Using index info to reconstruct a base tree...
M	networking/ingress-operator.adoc
Falling back to patching base and 3-way merge...
Auto-merging networking/ingress-operator.adoc
CONFLICT (content): Merge conflict in networking/ingress-operator.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-15219 Creating a Custom Ingress Controller
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bscott-rh: #66188 failed to apply on top of branch "enterprise-4.13":

Applying: OCPBUGS-15219 Creating a Custom Ingress Controller
Using index info to reconstruct a base tree...
M	networking/ingress-operator.adoc
Falling back to patching base and 3-way merge...
Auto-merging networking/ingress-operator.adoc
CONFLICT (content): Merge conflict in networking/ingress-operator.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-15219 Creating a Custom Ingress Controller
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bscott-rh: new pull request created: #77244

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bscott-rh: new pull request created: #77245

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bscott-rh: new pull request created: #77246

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jmanthei 4.14-4.16 have been merged, but 4.12 and 4.13 had conflicts. Let me know when you have cherrypicks for 4.12 and 4.13 and I'll merge them

bscott-rh avatar Jun 10 '24 15:06 bscott-rh

@bscott-rh I'll double check with my SMEs, but there shouldn't be any merge conflicts as I'm adding a whole module to an assembly...

jmanthei avatar Jun 10 '24 16:06 jmanthei

@jmanthei I would recommend creating manual cherrypick PRs locally to see what the merge conflicts are. Let me know if you'd like a hand with that.

bscott-rh avatar Jun 11 '24 17:06 bscott-rh