Brian Clifton

Results 245 comments of Brian Clifton

hmm... not sure what went wrong..? @posix4e any ideas?

@flamsmark what about content fetched which includes a tracking ID? ex: `http://example/tracking.jpg?id=123456` Multiple fetches using that tracking ID could establish a browsing pattern (on the 3rd party site)

@flamsmark good call! Having a catch-all (regardless of file type) sounds great 😄

@jumde do you mean the aggregate numbers presented on the new tab page? or the shields themselves? As @eljuno mentions, you can see the breakdown (although, it could be organized...

@ryanml Ideally, I think it would look like the 2nd one you have there. This would be a good feature to check existing browsers to see how it gets handled...

@eljuno that is a different issue (where a form autofill is populating hidden user/password fields)

IIRC, the username/password are only auto-populated if you have Brave's default password manager enabled. Would need to check though

Unintentionally resolved with https://github.com/brave/brave-variations/pull/326 (production) I merged the change to staging with https://github.com/brave/brave-variations/pull/328

Whoops- accidentally closed when I did a rebase there. Apologies @akshay24495 has a fix in https://github.com/brave/brave-core/pull/12849

Re-opening; seems the changes made with https://github.com/brave/brave-core/pull/12849 didn't work as expected @akshay24495 would you be up for looking at this again? I suspect one of the following: 1. the solution...