Brian Clifton
Brian Clifton
We may need to revisit - but going to close this for now. If this gets opened again (intermittent issue), I'll take a look. Interesting it's only having a problem...
Related https://github.com/brave/brave-browser/issues/24130
WIP happening with https://github.com/brave/brave-ios/pull/4952 - working through some more details before we revisit 😄
Oh wow - this'll be a great one! (adding Cyrillic support). I can pull down and try after it's rebased ++ on everything @petemill mentioned 😄 Many of the UIs...
@danklad can you please create an issue describing the problem you're solving? (so we can use the closing keyword syntax) Thanks 😄
Built this yesterday and gave a run through now (there have been two updates since then). Here's what I saw: - Clicking the BAT triangle brought up this dialog (spacing...
Much better! Looks really nice 😄
We don't have an integration using this... yet! But https://github.com/brave/brave-core/pull/13387 will definitely be using this code 😄 See more details in https://github.com/brave/security/issues/933#issuecomment-1169200217 Code LGTM - but would leave to @evq...
cc: @mattmcalister @fallaciousreasoning
Needs discussion; marking as blocked for now This is not a blocker for the release though