Brian Sardo

Results 235 comments of Brian Sardo

Discussed in backlog. Let's add details on the algorithm on this ticket and then add another row in the PBS features table in the docs (https://docs.prebid.org/prebid-server/features/pbs-feature-idx.html) just after circuit breaking...

@scr-oath let's discuss this week.

We'll discuss this at the next engineering subcommittee meeting.

This is still on our radar for an upcoming engineering subcommittee meeting. We should have time to discuss it tomorrow.

@scr-oath let's discuss this week. @linux019 raised the point that the file you are modifying is auto-generated.

> There is an issue, this module requires CGO, but PBS traverses all modules files subtree and and adds all modules to autoload. Agreed @linux019. We'll need to find another...

LGTM. I will run a couple of manual tests this week with the goal of getting this into the 3.18.0 release.

@osazos please provide a link to an opened docs PR in the description.

Hi @ogbonnaEmmanuel, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from `v2` to `v3`. For example: ``` import ( "github.com/prebid/prebid-server/v3/adapters"...

I'm not sure what happened here but something went awry when you merged with master as nearly every file is showing as modified. Please fix and resubmit.