prebid-server New Adapter: ResetDigital

This PR adds a new adapter for Reset Digital to the Prebid Server (Go version). The adapter enables Prebid Server to communicate with Reset Digital for real-time advertising auctions.

Changes:

Added the Reset Digital adapter in adapters/resetdigital/. Implemented necessary methods for the adapter. Added unit tests for the adapter in adapters/resetdigital/resetdigital_test.go. Updated the documentation to include the configuration for the Reset Digital adapter. Testing:

Unit tests have been written and verified to ensure the adapter works correctly. Manual testing has been performed to verify the integration with Reset Digital.

Notes:

This system is based on single bid, so it's based on that premise.

Related Issues:

This PR continues the unfinished work on #3452

Jun 20 '24 21:06 bruno-siira

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 37626768b3a11102896d069f1323277d9d8d02df

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:57:	Builder			0.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:69:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:86:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:94:	getReferer		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:102:	getCurrency		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:110:	MakeRequests		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:151:	processDataFromRequest	94.4%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:186:	MakeBids		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:222:	getBidFromResponse	93.3%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:257:	getBidPrice		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:264:	getBidType		28.6%
total:										(statements)		74.2%

Jun 20 '24 21:06 github-actions[bot]

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 989c565f97c46d367d248b73091a68877b4c3f8b

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:57:	Builder			0.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:69:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:86:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:94:	getReferer		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:102:	getCurrency		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:110:	MakeRequests		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:151:	processDataFromRequest	94.4%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:186:	MakeBids		78.9%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:222:	getBidFromResponse	92.3%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:255:	getBidPrice		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:262:	getBidType		28.6%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:274:	getBidTypes		70.0%
total:										(statements)		74.5%

Jul 03 '24 13:07 github-actions[bot]

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 4482bc93108566449cf4c28e3dbe9fc2b12ad37a

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:55:	Builder			0.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:67:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:84:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:92:	getReferer		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:100:	getCurrency		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:108:	MakeRequests		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:149:	processDataFromRequest	94.4%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:184:	MakeBids		78.9%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:220:	getBidFromResponse	92.3%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:253:	getBidPrice		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:260:	getBidType		28.6%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:272:	getBidTypes		70.0%
total:										(statements)		74.5%

Jul 05 '24 16:07 github-actions[bot]

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, d426e8a00853fc5e4887964c90f5617d14de0dc9

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:55:	Builder			0.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:67:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:84:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:92:	getReferer		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:100:	getCurrency		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:108:	MakeRequests		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:152:	processDataFromRequest	89.5%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:186:	MakeBids		78.9%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:222:	getBidFromResponse	92.3%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:255:	getBidPrice		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:262:	getBidType		28.6%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:274:	getBidTypes		70.0%
total:										(statements)		72.7%

Jul 09 '24 21:07 github-actions[bot]

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, ac2fc0188ac75f8b88ad4ea045f34b7c60bc54a9

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:55:	Builder			0.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:67:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:84:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:92:	getReferer		0.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:100:	getCurrency		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:108:	MakeRequests		64.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:145:	processDataFromRequest	89.5%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:179:	MakeBids		78.9%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:215:	getBidFromResponse	92.3%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:248:	getBidPrice		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:255:	getBidType		28.6%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:267:	getBidTypes		70.0%
total:										(statements)		70.8%

Jul 09 '24 21:07 github-actions[bot]

@bruno-siira please add or link bidder docs PR for adapter.

Jul 10 '24 11:07 onkarvhanumante

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 52a67946255e2add1a3f0f9e891ca9a2edb992cf

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:55:	Builder			0.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:67:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:84:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:92:	getReferer		0.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:100:	getCurrency		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:108:	MakeRequests		64.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:145:	processDataFromRequest	88.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:180:	MakeBids		78.9%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:216:	getBidFromResponse	92.3%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:249:	getBidPrice		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:256:	getBidType		28.6%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:268:	getBidTypes		70.0%
total:										(statements)		70.2%

Jul 16 '24 16:07 github-actions[bot]

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 9626103356397a1452bb31805a70aed11cb0d8b7

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:55:	Builder			0.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:67:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:84:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:92:	getReferer		0.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:100:	getCurrency		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:108:	MakeRequests		64.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:145:	processDataFromRequest	88.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:180:	MakeBids		78.9%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:216:	getBidFromResponse	92.3%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:249:	getBidPrice		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:256:	getBidType		28.6%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:268:	getBidTypes		70.0%
total:										(statements)		70.2%

Jul 18 '24 17:07 github-actions[bot]

@bruno-siira, requesting to address these open comments

https://github.com/prebid/prebid-server/pull/3766/files#r1672062595 https://github.com/prebid/prebid-server/pull/3766/files#r1686303431 https://github.com/prebid/prebid-server/pull/3766/files#r1672052739 https://github.com/prebid/prebid-server/pull/3766/files#r1672049306 https://github.com/prebid/prebid-server/pull/3766/files#r1686306246 https://github.com/prebid/prebid-server/pull/3766/files#r1671947510 https://github.com/prebid/prebid-server/pull/3766/files#r1672082625 https://github.com/prebid/prebid-server/pull/3766/files#r1671959851 https://github.com/prebid/prebid-server/pull/3766/files#r1672044232 https://github.com/prebid/prebid-server/pull/3766/files#r1672009993 https://github.com/prebid/prebid-server/pull/3766/files#r1672013186 https://github.com/prebid/prebid-server/pull/3766/files#r1672083212 https://github.com/prebid/prebid-server/pull/3766/files#r1672082881 https://github.com/prebid/prebid-server/pull/3766/files#r1672082770 https://github.com/prebid/prebid-server/pull/3766/files#r1672082625 https://github.com/prebid/prebid-server/pull/3766/files#r1672017626 https://github.com/prebid/prebid-server/pull/3766/files#r1672084154 https://github.com/prebid/prebid-server/pull/3766/files#r1672014001 https://github.com/prebid/prebid-server/pull/3766/files#r1672083451

Jul 22 '24 10:07 onkarvhanumante

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, dea6cf703ca30911c5e5c50b72da06cf6f3e2fd3

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:55:	Builder			0.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:67:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:84:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:92:	getReferer		0.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:100:	getCurrency		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:108:	MakeRequests		64.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:145:	processDataFromRequest	88.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:180:	MakeBids		76.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:220:	getBidFromResponse	92.3%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:253:	getBidPrice		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:260:	getBidType		28.6%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:272:	getBidTypes		70.0%
total:										(statements)		69.8%

Jul 24 '24 23:07 github-actions[bot]

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, baa553c3646faf043d7db5e693b59fafc427b150

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:70:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:81:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:98:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:106:	MakeRequests		62.5%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:143:	processDataFromRequest	73.9%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:193:	MakeBids		75.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:242:	getBidFromResponse	87.5%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:266:	getBidType		28.6%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:278:	getBidTypes		0.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:297:	GetMediaTypeForImp	66.7%
total:										(statements)		65.1%

Aug 29 '24 15:08 github-actions[bot]

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, ecc90bb8773699cc10e71495d3c527b80bd3af6d

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:66:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:77:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:94:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:102:	MakeRequests		62.5%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:139:	processDataFromRequest	69.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:197:	MakeBids		76.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:249:	getBidFromResponse	58.3%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:279:	getBidType		28.6%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:291:	GetMediaTypeForImp	66.7%
total:										(statements)		68.2%

Sep 10 '24 10:09 github-actions[bot]

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 0d54a8d13f7a652fc10815bd7efcc8bfa3ce36d2

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:66:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:77:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:94:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:102:	MakeRequests		62.5%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:139:	processDataFromRequest	93.1%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:197:	MakeBids		76.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:249:	getBidFromResponse	58.3%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:279:	getBidType		57.1%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:291:	GetMediaTypeForImp	83.3%
total:										(statements)		77.6%

Sep 29 '24 21:09 github-actions[bot]

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 613317a5e48b5a85e0a34223912353cf87c88a08

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:66:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:77:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:94:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:102:	MakeRequests		87.5%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:139:	processDataFromRequest	96.6%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:197:	MakeBids		77.8%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:251:	getBidFromResponse	75.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:280:	getBidType		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:292:	GetMediaTypeForImp	83.3%
total:										(statements)		87.2%

Oct 31 '24 20:10 github-actions[bot]

Hi @ogbonnaEmmanuel, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3. For example:

import (
    "github.com/prebid/prebid-server/v3/adapters"
)

As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

Nov 04 '24 17:11 bsardo

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, d212d91e8c04514713d1fc3bad0f820ab3cb93d7

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:67:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:78:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:103:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:111:	MakeRequests		87.5%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:148:	processDataFromRequest	97.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:219:	MakeBids		81.5%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:273:	getBidFromResponse	80.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:298:	getBidType		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:310:	GetMediaTypeForImp	87.5%
total:										(statements)		89.7%

Nov 04 '24 21:11 github-actions[bot]

I'm not sure what happened here but something went awry when you merged with master as nearly every file is showing as modified. Please fix and resubmit.

Nov 05 '24 16:11 bsardo

@bsardo , I think that this PR is ready for review again. But, please let me know if you have additional requests before you can review it again.

Nov 12 '24 16:11 dirk-rd

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, ef65f7b2126325893821a1987bcf710074669164

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:67:	Builder			80.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:78:	getHeaders		100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:103:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:111:	MakeRequests		87.5%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:148:	processDataFromRequest	97.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:219:	MakeBids		81.5%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:273:	getBidFromResponse	80.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:298:	getBidType		100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:310:	GetMediaTypeForImp	87.5%
total:										(statements)		89.7%

Dec 02 '24 17:12 github-actions[bot]

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 6bac6cdf3cd1211930490d9cc6ed6af56b4fda95

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:67:	Builder			80.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:78:	getHeaders		100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:103:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:111:	MakeRequests		87.5%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:149:	processDataFromRequest	97.1%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:209:	MakeBids		88.9%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:261:	getBidFromResponse	100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:286:	getBidType		100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:298:	GetMediaTypeForImp	100.0%
total:										(statements)		93.9%

Dec 04 '24 03:12 github-actions[bot]

@BrunoJacinto, I think this PR is ready for another review, please.

Dec 07 '24 01:12 dirk-rd

@BrunoJacinto, I think this PR is ready for another review, please.

Ok Dirk, I'll review it from my part.

Dec 07 '24 10:12 bruno-siira

Ugh, I tagged Bruno instead of Brian. I meant to let @bsardo know that the PR is ready for another review.

Dec 10 '24 16:12 dirk-rd

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 06233161c9e78a3be0c7d7fc3d82ddae699d16cd

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:67:	Builder			80.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:78:	getHeaders		100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:103:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:111:	MakeRequests		87.5%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:149:	processDataFromRequest	97.1%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:209:	MakeBids		95.8%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:257:	getBidFromResponse	100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:282:	getBidType		100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:294:	GetMediaTypeForImp	100.0%
total:										(statements)		95.5%

Dec 22 '24 20:12 github-actions[bot]

@bsardo, this PR is once again ready for review.

Dec 22 '24 20:12 dirk-rd

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 8ed4059524d8948cd838abe6a0df30942a8ef95e

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:67:	Builder			80.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:78:	getHeaders		100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:103:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:111:	MakeRequests		87.5%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:149:	processDataFromRequest	97.1%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:209:	MakeBids		85.7%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:262:	findRequestImpByID	75.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:271:	getBidFromResponse	100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:296:	getBidType		100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:308:	GetMediaTypeForImp	100.0%
total:										(statements)		92.9%

Jan 10 '25 21:01 github-actions[bot]

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, fe2c572816d90792c171d00574e8e425660f01d4

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:67:	Builder			80.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:78:	getHeaders		100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:103:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:111:	MakeRequests		87.5%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:149:	processDataFromRequest	97.1%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:209:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:253:	findRequestImpByID	100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:262:	getBidFromResponse	100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:287:	getBidType		100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:299:	GetMediaTypeForImp	100.0%
total:										(statements)		96.4%

Jan 25 '25 22:01 github-actions[bot]

Ready for review again, @bsardo, please!

Jan 25 '25 22:01 dirk-rd

@bruno-siira - are there any differences between this and the PBS-Java version of your adapter or is this a direct port?

Jan 30 '25 15:01 bretg