bryngemark

sw dev consensus: most of these tests aren't really contributing beyond validation. we should rather use this space for _unit tests_. so we suggest - delete configs that are already...

That's an idea. The electron counter sets the number of electrons so if that's run in the validation configs, that number can be pulled from the event header by any...

The failing histogram tests are caused by a name change `clusterless` --> `unclustered` (which in turn is no biggie, just reflects the difference in perspective between a more seasoned particle...

reopening just to follow our standard workflow (which is good for new developers to learn 🙂 ) : mention the issue you're solving in the PR, and once the PR...

> [@cjbarton151](https://github.com/cjbarton151) how does what you did compare to what [@Layan-Sarayra](https://github.com/Layan-Sarayra) did in `iss1760-light-pipes-ts`, is it the same thing? as far as i know @cjbarton151 started from what @Layan-Sarayra had...

SiPM specs: https://drive.google.com/file/d/1brglsz5YRwCForbn9zg2p67zKofDmSiW/view

i think this solution sounds good (and it solves the longstanding nuisance of three-fold repetition of the TS geometry). i agree we don't need separate SDs for the SiPMs and...

You might be right @tomeichlersmith that visualization and clustering are conceptually separate... even if they were used in tandem for this project. Do you have some handy github wizardry that...

thank you for stepping in @tomeichlersmith ! do you think you could try to understand why this branch breaks the overlay producer? what i see is that the ecal simhits...

that's great, @tomeichlersmith. i was getting hopeful when the validation pileup test went through. i ran on ella's dev branch (that the PR was made from) locally on my laptop....