Bryan Spears

Results 18 comments of Bryan Spears

That does sound like a good feature. However, the view displayed above shows "for google.com" but shows all domains (for all URLs processed) in the table. I don't see that...

This hack has worked for me thus far. Any issues with this? If not, I could whip up a PR soon. ``` waitFor = getPath(this, opts.waitFor); if (!opts.waitFor || waitFor...

So how would you wait for collections to be populated? If you `waitFor: 'model.collection.length` that would work in the current code, however, what if the collection truly has no models?...

Just to be clear, it's not just a length problem. It actually creates an empty model in the collection.

Ahhh. It's a problem in ampersand-state: https://github.com/AmpersandJS/ampersand-state/blob/master/ampersand-state.js#L167 Shouldn't ampersand-state let the collection decide what to do with the data? This creates inconsistent behavior between state and collection when used together...

My confusion stemmed from the fact that `renderSubview()` functions differently than the subviews hash. The `renderSubview()` method appends to container/this.el where subview replaces. I'm not sure I mind which way...

Could this please get some more attention? It's odd to have the subviews hash and renderSubview() work differently. Muddles up the code and template each time I have to remember...

Hey @cdaringe. I appreciate the quick response! So the idea would be to group two input views in another view to validate the updates? Also, I'd be interested to see...

I started doing something very similar to the password-view after your original comment. However, doesn't this mean I have to re-implement much of what &-input-view already does for me? Error...

So I've played around with the three different ways of doing this I've discovered so far. They all feel horribly clunky. We already have one example of validation based on...