Bryan Garza

Results 59 comments of Bryan Garza

If the `tracing-core` tests pass, I think we should merge it and follow up with more PRs

@jswrenn if this won't get merged soon, let's point the PR (or make a separate one) for the `valuable` branch, so we can keep going with the refactor. I'll put...

> why does this need to be pointed at the `valuable` branch? @hawkw I commented on the wrong PR, it was meant for https://github.com/tokio-rs/tracing/pull/2292 😅

Hi -- this one must have fallen through the cracks. I'm no longer contributing to tracing; if anyone is interested in following up on this, you should probably reach out...

No worries, thanks for getting back to it!

I was on `6a1703eb2345e3508d6b59e690c170ac3e02b7a7` which I got from ``` git clone -b release/0.2 https://github.com/pytorch/executorch.git third-party/executorch ``` https://github.com/pytorch/executorch/commits/release/0.2/ @Gasoonjia which 0.2 branch do you mean?

Just tried the tutorial from scratch, new conda env and everything, but still getting the same error on `release/0.2`. Could you share which commit hash or PR addressed the error?...

too bad this never got merged, it would have been useful

Thanks @Gasoonjia! I tried it again by pulling `release/0.2` and rebuilding. It's working for me now.