Bryan Garza

Thanks for your comments @hawkw! I do think it'd be great to incrementally merge changes into another branch, otherwise the PR is going to take forever. I created the `valuable`...

> thinking about this a bit more --- i mentioned in a few places that we might want to completely remove the `FieldSet` and `ValueSet` types, e.g.: > > >...

Oh okay, that makes mores sense

Okay, I think the rest of the upcoming changes (namely, deleting/replacing FieldSet, and deleting some of the now-unneeded code) and updating the rest of `tracing-core` to match) can be done...

Let's rebase and merge this one?

Any update on this one @koute?

@hawkw Need direction on this PR, do we want to merge/do we need additional changes if so?

> * [ ] Is the signature of `on_register_dispatch` correct? > > * Should it take `&Dispatch`, or `&mut Dispatch`? > * Should it take `&self`, or _only_ the `&Dispatch`...

@jswrenn I think it's failing CI cause of clippy

Is this still something we want to merge @hawkw ?