tracing icon indicating copy to clipboard operation
tracing copied to clipboard

Published 20 hours ago • verified publisher icon tokio-rs

tracing-core: `Valuable` everywhere

Open jswrenn opened this issue 2 years ago • 2 comments

Applies the approach described here. Namely, this PR replaces:

  • tracing::FieldSet with &[valuable::NamedField<'static>]
  • tracing::Record and tracing::ValueSet with valuable::NamedValues
  • tracing::Value with valuable::Valuable

jswrenn avatar Aug 24 '22 23:08 jswrenn

I made a similar change in my branch but yours deletes more, so I think we should go with this. With the direction we're going in, the entire field.rs is basically a wrapper for valuable, so I agree with deleting it entirely.

bryangarza avatar Aug 24 '22 23:08 bryangarza

If the tracing-core tests pass, I think we should merge it and follow up with more PRs

bryangarza avatar Aug 25 '22 00:08 bryangarza