Bruno Oliveira

Results 82 comments of Bruno Oliveira

> The sample app ~also~ contains the following database context class: > > dead wood Does "dead wood" mean something special here? 😂

> I made commit with changes that I think would improve API here. I have added enum describing state of model binding (set/null/empty body). All the logic checking if model...

> So isn't this a problem with entire handling of model binding of `"null"` json on nullable parameter with `TreatEmptyInputAsDefaultValue==true`? I do not think that the condition is wrong just...

> I am not sure if I understand correctly how it deals with nullable types. When I run test with (/contact is simple endpoint with Contact class object argument from...

> @brunolins16 I have made suggested changes to SytemTextJsonInputFormatter and added tests for it. The question is should I do something with ApiBehaviorTest since it currently relies on SystemTextJsonInputFormatter being...

@senbar I just took a look and i think the easiest way is to add the new Functional Tests to https://github.com/brunolins16/aspnetcore/blob/main/src/Mvc/test/Mvc.FunctionalTests/SystemTextJsonInputFormatterTest.cs , instead `APIBehaviorTests`, similar to what we have here:...

> Sorry have been busy last weeks, I will be finishing PR soon @senbar are you still planning to work on it? Can I help you on anything?

Don't worry about it, take your time. I was just checking if I could do anything to help.

> At this stage the concern might be the risk of any change. How close are we to final build? I am not sure how close we are but @dougbu...

> Not sure when the Learn Portal gets updated. However, wouldn't this PR improve the IntelliSense experience❔ No. The IntelliSense experience is **not** broken right now.