AspNetCore.Docs icon indicating copy to clipboard operation
AspNetCore.Docs copied to clipboard

Problem details /2

Open Rick-Anderson opened this issue 1 year ago • 9 comments

contributes to #26685

Internal review URL sample code

Rick-Anderson avatar Sep 15 '22 01:09 Rick-Anderson

Public review of the doc build:

  • download the HTML files
  • unzip
  • view HTML file in a browser.
  • For links outside the doc, remove the review. from URL. @sammychinedu2ky start at

Client error response

Rick-Anderson avatar Sep 21 '22 02:09 Rick-Anderson

Public review of the doc build:

  • download the HTML files
  • unzip
  • view HTML file in a browser.
  • For links outside the doc, remove the review. from URL. @sammychinedu2ky start at

Client error response

Thanks @Rick-Anderson 😅, but I wasn't able to see how the problem was resolved since the controller writes the problem details to stream before the middleware handles it.

Since there is no way around it than changing the controller like this:

image

Should I leave the code in the issue as it is since you explained why in the post?

sammychinedu2ky avatar Sep 21 '22 06:09 sammychinedu2ky

Should I leave the https://github.com/dotnet/AspNetCore.Docs.Samples/issues/60as it is since you explained why in the post?

No, do a PR and create a 3rd controller named Values3Controller. After explaining the problem we'll show the work around.

Rick-Anderson avatar Sep 21 '22 19:09 Rick-Anderson

Should I leave the https://github.com/dotnet/AspNetCore.Docs.Samples/issues/60as it is since you explained why in the post?

No, do a PR and create a 3rd controller named Values3Controller. After explaining the problem we'll show the work around.

I can only see one controller from my end or am I mistaken?

sammychinedu2ky avatar Sep 21 '22 19:09 sammychinedu2ky

@Rick-Anderson

sammychinedu2ky avatar Sep 21 '22 19:09 sammychinedu2ky

https://github.com/dotnet/AspNetCore.Docs.Samples/blob/main/fundamentals/middleware/problem-details-service/Controllers/ValuesController.cs#L39

2 controllers, one file. Put the 3rd controller in the same file.

Rick-Anderson avatar Sep 21 '22 19:09 Rick-Anderson

https://github.com/dotnet/AspNetCore.Docs.Samples/blob/main/fundamentals/middleware/problem-details-service/Controllers/ValuesController.cs#L39

2 controllers, one file. Put the 3rd controller in the same file.

Ooh I need to pull, I don't have this locally 😅

sammychinedu2ky avatar Sep 21 '22 20:09 sammychinedu2ky

Ooh I need to pull, I don't have this locally 😅

Never do a PR from your old branch.

Rick-Anderson avatar Sep 21 '22 21:09 Rick-Anderson

Ooh I need to pull, I don't have this locally 😅

Never do a PR from your old branch.

Sure thanks

sammychinedu2ky avatar Sep 21 '22 21:09 sammychinedu2ky

The sample app ~also~ contains the following database context class:

dead wood

Rick-Anderson avatar Sep 23 '22 21:09 Rick-Anderson

The sample app ~also~ contains the following database context class:

dead wood

Does "dead wood" mean something special here? 😂

brunolins16 avatar Sep 23 '22 21:09 brunolins16