Bruno Oliveira
Bruno Oliveira
/benchmark json aspnet-perf-win mvc
> Are we calling a new API that isn't public? The source generator needs to copy this pattern as well. > > cc @captainsafia I just merged #45593 that makes...
@eiriktsarpalis I believe I covered almost all the feedback. Do you have any additional concern before I merge it?
Service approved by email. @dotnet/aspnet-build can someone help me with this PR merge?
I have been thinking about this proposal and one thing that, since the initial proposal, annoyed me is that we are adding an option to `ProblemDetailsOptions` that will not be...
@commonsensesoftware appreciate your thoughts and **option 2** is not bad but I really believe we could try simplifying instead over engineering it. We can have the `DefaultProblemDetailsWriter` public and probably...
@commonsensesoftware Sorry, I am not quite sure if I understood your point. > The ProblemDetailsService implementation uses the last registered IProblemDetailsWriter where CanWrite returns true as seen at: The `ProblemDetailsService`...
I would keep the `if (_writers.Length == 1)` but the other suggestions look good. If you are interested feel free to open a PR or I can try open a...
> Sure. I can spin up a PR. > > What is gained (or retained) by keeping the branch for `if (_writers.Length == 1)`? Since `_writers_ supports indexing, I don't...
@commonsensesoftware that is right. I ended up implementing everything as part of another work I did. Sorry if you spent time in this PR.