Bruno Garcia
Bruno Garcia
> Took me a while to understand why, but it's just because ParseScript itself cannot be reached with ctx == ParseScriptContext::WPKH. Perhaps an assert or Assume could be added for...
Can be tested with the following diff: ```diff diff --git a/src/net_processing.cpp b/src/net_processing.cpp index 5dac413319..ec417b97ac 100644 --- a/src/net_processing.cpp +++ b/src/net_processing.cpp @@ -3535,7 +3535,7 @@ void PeerManagerImpl::ProcessMessage(CNode& pfrom, const std::string& msg_type, LOCK(pfrom.m_subver_mutex);...
> Thanks for reporting, we can address this. Seems like just an API mismatch (discarding the extra bytes vs erroring) though I think we should match bitcoind's behavior here. Sounds...
Can you please rebase?
> > Can you please rebase? > > Done! Can you approve the workflow? @brunoerg Just approved it.
I can review this today but needs rebase.
> > I can review this today but needs rebase. > > Done. Need workflow approval! Approved.
Did you get this code from bitcoinfuzz v1 (master branch)?
I think you need to rebase, there is a silent conflict?