Brian R. Murphy

[Feature Request][move-compiler-v2] More useful error message for bytecode verification failures

1

# 🐛 Bug We could try to generate a slightly more user-friendly error message in case we have any errors that slip through after launch. For beta launch, we might...

[Feature Request][move-compiler-v2] Parallel .exp files for all tests to be able to regression-test Compilers V1 and V2 in parallel for a while

3

# 🚀 Feature Request As Compiler V2 is able to work on most things, we increasingly need to have regression test output for V2 for *all* tests involving the compiler...

[Bug][move-compiler-v2] Disassembler output combines address and module name in call

1

# 🐛 Bug See https://github.com/aptos-labs/aptos-core/blob/851f9ee81b9b2dcc6be69d1a8a81a005f9415b0b/third_party/move/move-compiler-v2/tests/file-format-generator/vector.exp: ``` 90: 4: Call 1vector::reverse(&mut vector) ``` it seems that address `1` and module name `vector` are being merged together here. This is not good....

[Bug]Unknown manifest field "upgrade_policy"

2

# 🐛 Bug The field "upgrade_policy" appears in a number of Aptos Move examples and e2e-move tests, but the manifest_parser doesn't know about it. It shows up as a warning...

[Bug][move-compiler-v2] move-compiler-v2/tests/v1.matched tests have diverged from v1

7

# 🐛 Bug Various of the move-compiler-v2 test files that are allegedly equivalent to v1 tests have diverged from the originals. To accurately assess divergence between V1 and V2 we...

[Feature Request][move-compiler-v2] coverage report should not include code inlined from non-target deps

1

# 🚀 Feature Request See https://github.com/aptos-labs/aptos-core/pull/12240, which is a hack to workaround this problem in one particular case. The bigger problem is that inlined code should not be counted in...

Run MOVE_COMPILER_V2 with more tests and record outputs in .v2_exp files

2

## Description Updated various test harnesses and re-ran pretty much all .move tests with `MOVE_COMPILER_V2=true` to generate .v2_exp files to see what V2 does today. Diffed outputs with V1 outputs...

# 🐛 Bug The tests fail because the address `A` is changed in dependencies. This is no longer allowed in V2. We need new tests to exercise the desired functionality....

[Bug][move-compiler-v2] compiler-v2 fails vm_test_harness/example.move test

1

See ``` third_party/move/testing-infra/transactional-test-runner/tests/vm_test_harness/example.v2_exp ``` in #13216 . There might be some problem with the test harness, but `task 4` of the test case fails compilation with `MOVE_COMPILER_V2=true`.

🐛 Bug V1 passes the test (no .exp file), while V2 fails it (see the .v2_exp file): ``` diff: ./third_party/move/move-prover/tests/sources/regression/vector_theory_smt_seq.exp: No such file or directory Move prover returns: exiting with...