Berkay Karaman

Results 65 comments of Berkay Karaman

@mitsudome-r There is a package called control_performance_analysis in Control. I am confused, is purpose of this issue develop this package? Or, this package is not going to be used anymore...

Here is my initial control benchmark tool proposal: ![benchmark drawio](https://user-images.githubusercontent.com/45468306/161766175-6cea949d-c289-46f6-b5f3-8c3ba5691930.png) I wrote there possible outputs from `observation and evaluation node`. The advantage of this architecture, we can test the all...

We decided to modify the ` control_performance_analysis` package. I will add new functionalities to this package. New design is here: ![control benchmark design](https://user-images.githubusercontent.com/45468306/162393921-a99fc054-bec4-4280-bd8e-b6a5066880b6.png) I will create PR for this design....

@mitsudome-r control_performance_analysis package updated and merged into main. I am going to evaluate the current controllers, and I will update them if I see any improvements. Also, I am going...

Example usage of control performance analysis tool: https://github.com/orgs/autowarefoundation/discussions/412#discussioncomment-2947841

Tests were made in universe with commit sha: `aa576c066adc93721e24403723291998a47109a0` with default parameter values. **To reproduce the tests:** * Download the scenario that used in my test: [link](https://file.io/RxKeLMqmUKzU). * Run `scenario_simulator`...

https://github.com/facontidavide/PlotJuggler/issues/506#issuecomment-913114058 I know this comment, but I tried to increase `buffer_size` to 500 sec but I couldn't see the data in 500 sec range.

Sorry I couldn't review this PR because I was busy with other works. And, I can not review for next 2 week because I am going to take annual leave.

Hello again, It seems that I am not going to available this month because of vehicle tests. So, I won't be able to review this PR. I am sorry for...

> @brkay54 How's it going I was in BUS ODD tests, and I tested with real vehicle. I couldn't see any problem. But I couldn't test it in planning simulator....