Brian Smith
Brian Smith
If cranelift already supports aes then it should be relatively easy for it to support the other two missing crypto extensions. Probably a new contributor to cranelift could look at...
I looked at the cranelift repo and saw https://github.com/rust-lang/rustc_codegen_cranelift/issues/1522 which indicates that *ring* builds with cranelift just fine after they added the target feature detection.
One of the getrandom crate's maintainers has proposed something related to this in https://github.com/rust-random/getrandom/issues/498. I think we should resolve that issue and then revisit this once the getrandom issue is...
Thanks for the PR. I'm no longer accepting PRs for this project, but I appreciate your effort.
Any updates on this? Would love to get this resolved for the next release.
I think this is moot with the new loongarch toolchain, so I'm closing. Feel free to resubmit with the above feedback in mind, if I am overlooking something.
We can add a core-error feature flag to *ring* that will do this, I suppose. Not sure what the use case is.
This idea seems fine with me, but it'd need to be behind a feature flag because we aren't raising the MSRV yet.
Please provide the full steps to reproduce, including what you set `TARGET_CC` and `TARGET_AR` to, and especially what linker you are using, and what `cargo` command you are executing.
> This is what I get when I do cargo build: > > warning: [email protected]: cc1.exe: warning: C:\ring-main\ring-main\pregenerated: No such file or directory [-Wmissing-include-dirs] It looks like you're building ring...