Brian Smith

@SergioBenitez I saw your PR for the cookie-rs crate. Did you want AES-CTR for use in that crate, so that you could implement AES-CTR-HMAC-SHA256? If so, I'd be happy to...

@plietar In the case of https://github.com/plietar/librespot/blob/d940ed161a0d026d293275f6cfc28c32fada2880/src/authentication/discovery.rs#L130, isn't that AES-CTR-HMAC? Also, in the case of https://github.com/plietar/librespot/blob/d940ed161a0d026d293275f6cfc28c32fada2880/src/authentication/mod.rs#L91, isn't that AES-192-CBC? Right now we have to concentrate on improving the really good crypto...

I re-opened this. If somebody wants to work on a public API for AES-CTR, I am open to accepting that change. *ring* already has AES-CTR implemented in `aead::aes`. In order...

If/when we have a public API for AES-CTR with 96 bit nonces, it might also make sense to replace the direct uses of `aead:::aes` in `aead::aes_gcm` with use of the...

> I'm not sure what performance pitfalls are here, but I'd rather duplicate part of the codepath if needed. The AES-GCM implementation has benchmarks that you can run to verify...

Closing this based on the above comment.

We currently have a pattern `pub(crate) mod sealed { pub trait Sealed {} }` where a `T: sealed::Sealed` constraint guarantees that `T` is implemented within the current crate. `! :...