Results 1127 comments of Brian Smith

Since PR #2056 was merged, we'll need to wait for Rust 1.80 (IIUC) to become stable, or else add a wokaround that forces the use of nightly for the armv7...

Thanks for the PR. I definitely did want to switch to stable Rust for code coverage. This would have been a good improvement. Unfortunately, the branch coverage option hasn't been...

> Is the PR not relevant anymore? @briansmith PR #2070 is somewhat of an alternative to this PR that is more conservative because it doesn't increase the size of the...

@rohhamh Thank you for working on this. In https://github.com/RustCrypto/block-ciphers/issues/475 and https://github.com/RustCrypto/block-ciphers/issues/191 I attempted to transfer the knowledge from what we learned here to the RustCrypto team.

What do you get when you do this? ``` $ rustc --print=cfg --target i686-unknown-freebsd | grep sse debug_assertions target_feature="sse" target_feature="sse2" ``` For me, rustc indicates that sse and sse2 are...

At https://www.freebsd.org/releases/14.0R/hardware/#proc-i386, it is written: > 2.3. i386 Architecture Support > FreeBSD maintains support for i386 (x86) as a Tier 2 architecture. It is not recommended for new installations. >...

Note that you can build *ring* with `RUSTFLAGS="-C target-feature=+sse2"` (or whatever) to get it to work on those targets. Note that it might have built before I added these assertions,...

Yes, [the ](https://github.com/briansmith/ring/issues/1999#issuecomment-2151011318) also applies to that target.

I am open to addressing this issue but I don't intend to work on it myself any time soon except to review a PR that fixes it and which is...