Brian Littmann

Results 9 comments of Brian Littmann

I think this issue is being caused by having a video that is trimmed down from a longer video. For instance, I had a 2.5 minute (150 seconds) video from...

@facconi @momomatteo This isn't super clean, but using straight JS gives an accurate duration: ```typescript @ViewChild('video') videoChild video: any = {} loadVideoMetadata() { // Load metadata for video and get...

This is sort of equivalent to `window.onbeforeunload`. Regarding the solution by @leonsas, here is [the code](https://github.com/leonsas/ratchet/blob/175d313df3a800cd304e941d4633910b01117c16/js/push.js#L405-L412) added to push.js: ``` JavaScript var triggerSendEvent = function () { var e =...

As @slickdev mentioned, the issue lies in [lines 55-59](https://github.com/twbs/ratchet/blob/master/js/segmented-controllers.js#L55-L59) of segmented-controls.js: ``` javascript activeBodies = targetBody.parentNode.querySelectorAll(classSelector); for (var i = 0; i < activeBodies.length; i++) { activeBodies[i].classList.remove(className); } ``` `targetBody.parentNode`...

@nasiscoe — Curious, what is your hacky solution? Agree that merging this PR would be an easy win for accessibility.

Note: This works in Chrome (26), but appears to have adverse effects in Firefox (19) and makes IE 9 unresponsive. I probably shouldn't be filtering 8000+ elements anyway...

That's sort of a one-off solution. After you've filtered down to "gold", what happens if you delete all but one character, leaving "g"? Is it still slow? 1.5k elements shouldn't...

Yea, this was a bummer to hit. In the meantime, my workaround is thus: ```javascript let tokenId = (typeof token === "object" ? token.id : token) ```

@alexdesi I compromised and just had a root API module controller that inherited from `ActionController::Metal`. In there, I used `ActionController::Base.without_modules` to specify unneeded modules. Honestly though, unless performance is a...