inky icon indicating copy to clipboard operation
inky copied to clipboard

More accessible emails

Open davidpustai opened this issue 7 years ago • 7 comments

Problem

The tables in Inky's generated HTML are purely for styling purposes. For someone using a screen reader it gets really messy to understand the email (video demo).

Solution

Just add the WAI-ARIA role="presentation" to all the generated <table>s.

Solves

https://github.com/zurb/foundation-emails/issues/728

Resources

http://blog.gorebel.com/accessibility-in-email-part-ii/ https://css-tricks.com/html-email-accessibility/#article-header-id-0

davidpustai avatar Jun 19 '18 09:06 davidpustai

@rafibomb Still maintaining this repo in some way? Or is someone else? What do I have to do to get this moving?

I know the tests are failing, but they are at least partially failing because of last commit to v2.2, which is failing too. I was trying to fix it, but couldn't get my head around it. :baby:

davidpustai avatar Jun 20 '18 17:06 davidpustai

Checks failing due to repo owner name change. Could you restart the build of this PR? cc @garyanikin

davidpustai avatar Feb 06 '20 17:02 davidpustai

Checks failing due to repo owner name change. Could you restart the build of this PR? cc @garyanikin

I will rebase your PR so the CI changes are reflected.

DanielRuf avatar Aug 02 '20 22:08 DanielRuf

It seems there are several conflicts. Please check and resolve them.

Bildschirmfoto 2020-08-03 um 00 23 05

DanielRuf avatar Aug 02 '20 22:08 DanielRuf

Just bumping this PR because I think it's very important for accessibility! I'm currently using a hacky solution myself in light of this not being the default.

nicksiscoe avatar Feb 25 '22 18:02 nicksiscoe

@nasiscoe — Curious, what is your hacky solution? Agree that merging this PR would be an easy win for accessibility.

brianlittmann avatar Apr 11 '22 17:04 brianlittmann

@nasiscoe — Curious, what is your hacky solution? Agree that merging this PR would be an easy win for accessibility.

I just used a grep command in my build pipeline to manually add role presentation to all built email templates inside the table tag - not as elegant as it being supported out of the box :)

nicksiscoe avatar Apr 11 '22 19:04 nicksiscoe