Brian F.

Results 19 comments of Brian F.
trafficstars

Ran the tests locally and everything looked good from my end, all the components built and looked correct on their docs pages. @zeroedin - Can you confirm whether or not...

@marionnegp @coreyvickery @markcaron For `pfe-card` it looks like for 1:1 our coverage should be - Basic Card (title, body, footer) - Cards that can include any combination of the following...

Added a branch @ feat/pfe-card-pfv4 for this work https://github.com/patternfly/patternfly-elements/tree/feat/pfe-card-pfv4

Looks like this should link to https://ux.redhat.com/foundations/typography or perhaps more specifically to https://ux.redhat.com/foundations/typography/#desktop-scale

@bennypowers @coreyvickery - Hey Corey, this is currently being worked on now and being matched with PF4's styles at the moment. Took a little detour with setting up rh-tooltip but...

@coreyvickery @marionnegp - Have a demo up here https://deploy-preview-2114--patternfly-elements.netlify.app/components/accordion/demo/ for comparison to patternfly 1:1 if either of you have time to look at it and compare. Most of the visual...

@markcaron @bennypowers with regards to using the `details` html element for pfe-accordion currently the html setup looks like this: ```html Item one Lorem Ipsum Text ``` Right now with the...

Also, side question @marionnegp @coreyvickery, do we need to take design considerations for having an accordion inside of an accordion anymore? From looking at patternfly they default to the single...

Awesome, thanks @coreyvickery!

@marionnegp @coreyvickery - I have moved the PR out of Draft status & it is ready for review currently.