patternfly-elements icon indicating copy to clipboard operation
patternfly-elements copied to clipboard

[1:1] pfe-card

Open bennypowers opened this issue 2 years ago • 4 comments

Component name: <pfe-card>

Design specification updates

PatternFly v4 Card

We may defer implementation of expanded and selectable for now.

bennypowers avatar Jun 20 '22 07:06 bennypowers

Discussion thread around card: https://github.com/orgs/RedHat-UX/discussions/361

methomps avatar Jun 21 '22 15:06 methomps

@marionnegp @coreyvickery @markcaron

For pfe-card it looks like for 1:1 our coverage should be

  • Basic Card (title, body, footer)
  • Cards that can include any combination of the following
    • Title Header
    • Image Header
    • Body
    • Footer
  • Compact Card
  • Large Card

Do we want to also support for the first pass the following options:

Borders / Drop Shadows:

  • Flat (no drop-shadow, does have a border)
  • Rounded (sets a border radius)
  • Plain (No border or drop shadow)

Styling of the internals of the card itself:

  • Full-Height (Body takes up full height)
  • Card w/ dividers between sections (similar to how accordion can include borders between sections)

Actions What are they? pf v4 includes a menu and a checkbox item, presumably could be anything and would have to be provided functionality by the user? What do they include?

  • Card w/ image and actions
  • Card w/ title and actions
  • Card w/ actions and no title

As mentioned by @bennypowers previously we will likely need to defer expanded and selectable for now.

Keeping in mind too that whatever we add in here could be pfe specific if we think rhds is not going to need it.

brianferry avatar Oct 07 '22 14:10 brianferry

Added a branch @ feat/pfe-card-pfv4 for this work https://github.com/patternfly/patternfly-elements/tree/feat/pfe-card-pfv4

brianferry avatar Oct 13 '22 17:10 brianferry

@markcaron @marionnegp Seems fine for 1:1, are we missing anything else?

coreyvickery avatar Oct 14 '22 20:10 coreyvickery

Closed by #2222

bennypowers avatar Dec 22 '22 13:12 bennypowers