Results 228 comments of Brian C
trafficstars

Hey @yokyj thanks for the question! We could add a `.d.ts` file to this project...but I thought the normal approach was to add type definitions to [DefinitelyTyped](https://github.com/DefinitelyTyped/DefinitelyTyped) for projects that...

Hi! Sorry I'm a bit late to the party here - I'm one of the original authors on rosbag.js...lemme see if there's anything that's not gone answered yet & add...

Thanks for doing this! Can you include a test to reproduce the issue / prove its fixed? Without tests I am unlikely to merge PRs as they become a future...

> I'm sorry; I'm not going to find enough time to write this. While I greatly appreciate the work in fixing this, the PR will remain unmerged until a test...

yeah a proper "batched query" would be nice. Probably a separate object you pass to `client.query` or `pool.query` that was like ``` const batch = new BatchQuery({ name: 'optional', text:...

> is this supported? from a protocol perspective, yes. But I haven't actually implemented the code yet.

That'd be cool! I'd suggest making this a separate module like `pg-cursor` or `pg-query-stream`. It's fine to inline it into this repo as another module here, but best to keep...

https://github.com/brianc/node-postgres/blob/master/packages/pg-cursor/index.js#L42 This is a good point of reference.

not sure what to tell you here, but this library does absolutely 0 parsing or manipulating with your query text in any way. Can you make a script that's self-contained...

yeah that is very very bizarre and I have legit never seen this before in 12 years of maintaining this library.... 🤔 If you have a script that can reproduce...