fix(pg-query-stream): invoke `this.callback` on cursor end/error

[aleclarson]

trafficstars

Closes #2013

This issue was caused by two things:

• the Client wasn't using the callback argument that Pool#query passes with the QueryStream submittable
• the QueryStream wasn't attaching end/error listeners to its cursor, which it needs for calling its callback

[brianc]

Thanks for doing this! Can you include a test to reproduce the issue / prove its fixed? Without tests I am unlikely to merge PRs as they become a future bug waiting to re-occur! 😄

[peterp]

I think pg-copy-streams may suffer from the same issue, and am happy to provide a failure case/ test.

[aleclarson]

@peterp I believe you can send a PR to my fork and it'll show up here when I merge

[peterp]

@aleclarson I'm sorry; I'm not going to find enough time to write this.

[brianc]

I'm sorry; I'm not going to find enough time to write this.

While I greatly appreciate the work in fixing this, the PR will remain unmerged until a test case is submitted. I can't merge untested code as it becomes a forever maintenance burden for me in the future with no way to check for expected behavior.

[ashmit-coder]

@aleclarson Can you update your repo to latest. I maybe able to write the tests that we needed for this

[aleclarson]

@ashmit-coder 👍

[brianc]

@aleclarson I let CI run on this PR so it should letcha know if tests pass. 😄