Brian Avery
Brian Avery
This is exactly what I needed. Thanks!
This feature would be awesome to have.
/remove-lifecycle rotten
/remove-lifecycle stale
So the problem here is that the dialog has a context that it was opened under on the current page. When you navigate away from that page, the context is...
From https://github.com/shlomiassaf/angular2-modal/blob/master/src/lib/overlay/overlay.component.ts: ``` ngOnDestroy(): void { super.ngOnDestroy(); if (this.dialogRef.destroyed !== true) { // if we're here the overlay is destroyed by an external event that is not user invoked. //...
Thanks @ericvn. We have the label in istio/istio, but not here. I'll check why. Thanks for the feedback @sbs2001. I can see how this would be a challenge to parse....
Thanks for the issue. Maistra/OSSM 1.1 is based on Istio 1.4, so it will be a while before the deprecation affects us. However, the CRD issue that you mentioned does...
@howardjohn Looking through this, it looks feasible to me. What challenges are you expecting?