Brett McBride
Brett McBride
> Is there a guideline on how to implement tests and static analysis? Copy what PDO auto-instrumentation does :) Usually when starting a new auto-instrumentation, I just copy the one...
Everything you need should already be in core of the contrib repo. Once you've created your directory (`src/Instrumentation/Doctrine`) and copied in source etc , you can run `PHP_VERSION=8.3 PROJECT=Instrumentation/Doctrine make...
> what's the status of this project? any reason it wasn't continued? @evilpilaf we haven't heard from Cedric for quite some time. Do you have the skills to test this...
@moeyashi are you planning to work on this? I can assign it to you. Otherwise, I'll add a `help-wanted` label.
> HTTP span names SHOULD be {method} {target} if there is a (low-cardinality) target available. Instrumentation MUST NOT default to using URI path as a {target} This is the heart...
> why not at least use the hostname That's what was proposed in the linked PR. Can discuss over there: https://github.com/open-telemetry/opentelemetry-php-contrib/pull/305
- I'd like to understand _how_ this would be used by an instrumentation package. The metrics implementation is pretty extensive, does it already have features that can be used? I'd...
> Well we can copy and paste those classes all over but that would also be a bad practice. Agreed, that sounds awful! The most likely place is its own...
@GrzegorzDrozd I've submitted a PR to try to address this. In your case, do you have a detector which gives you a more static instance id that can be applied...
Discussion is still ongoing in the linked issue/PR. One workaround suggested would be to set `OTEL_RESOURCE_ATTRIBUTES=service.instance.id=my-stable-value`