Brett McBride

Results 292 comments of Brett McBride

Also affecting PHP codegen, for the same reasons as others: `{{ attribute.fqn | to_const_name }}` ends up with the same const name. For the time being, I can manually fix...

For PHP: - we have merged but not publicly released [file-based SDK configuration](https://github.com/open-telemetry/opentelemetry-php/tree/main/src/Config/SDK) using version `0.1` (status=`development`) - we are waiting on a 0.3 release to merge [file-based instrumentation configuration](https://github.com/open-telemetry/opentelemetry-php/pull/1304)...

> I wonder how consistent the implementations of this retry are It looks like not at all consistent, and I just found https://github.com/open-telemetry/opentelemetry-specification/issues/3639 which describes it quite well: > The...

> Or we could define a new retry type, with only a enabled property to start, with the intent to expand later when we decide on the options I like...

> Do you have interest in updating this PR to that effect? Updated to only implement retry.enabled (boolean, default true). The rest of the configuration will need to wait until...

> Is your concern that the name "rule_based" may collide later, if a native sampler of that name is added ? Not really, I think in that scenario we would...

> until someone successfully drives defining a rule based sampler at the spec level... I submitted an initial PR for a rule-based sampler, but it looks like [OTEP-250](https://github.com/open-telemetry/oteps/pull/250) encompasses this....

one more improvement here I thought of today, is that we could also add attributes to control the callback method/s for a function... eg `WithPreSpanCallback` or something like that? I...

> I think we should reconsider the namespace and rather make it part of [OpenTelemetry/API](https://packagist.org/packages/open-telemetry/api) so it can always be available in any project that uses the api package so...

> Yes, i think the attributes themselves should live in the API package and should be provided by the API package. Discussed at yesterday's SIG and agreed: https://github.com/open-telemetry/opentelemetry-php/pull/1371