Brent Yi

Results 331 comments of Brent Yi

Possibly dumb question: in the linked snippet, why are the kwargs used/needed at all? Like instead of: ```python return PatchPixelSamplerConfig().setup( patch_size=self.config.patch_size, num_rays_per_batch=num_rays_per_batch ) ``` Would this work? ```python return PatchPixelSamplerConfig(...

> For example, when the crop scale is set to 4, 4, 4, it is approximately equivalent to a square with a side length of 40 in the world coordinate...

This scale and how it's used might be interesting to you: https://github.com/nerfstudio-project/nerfstudio/blob/8e0c68754b2c440e2d83864fac586cddcac52dc4/nerfstudio/viewer/viewer.py#L51 Your [-20, -20, -20] should be divided by that ratio, which gets us to [-2, -2, -2]. That...

I need some more time to fully go through this but just wanted to say this looks really clean @jkulhanek! Not in scope here, but I'm wondering if there's a...

Hi! This is a good idea and sounds doable. One option is to: 1. Load the contents of the YAML into a config object _before_ any of the training script's`tyro`...

Hi Philipp — thanks for taking the time to try this. I experimented a bit with your implementation, and it seems like the sophisticated subcommands in `nerfstudio` make this problem...

Brief update: with https://github.com/brentyi/tyro/pull/33 merged and bundled in the latest release of `tyro` we are on track for getting this issue resolved. Wrapping up is on my to-do list but...

Sure, if nobody gets to it we can also chat about it in-person in January. My feeling is it might be worth automating this change? Seems like almost just a...

Appreciate the detailed example :) To me the main reasons for excluding the static fields are: - State dictionaries in Flax are expected to be mappings from strings to arrays...

Thanks for clarifying! I've run into similar issues, and something like the snippet you suggested sounds really useful. Main desired features on my end would be (1) better support for...