Brent Yi

Results 331 comments of Brent Yi

I haven't had any issues; the main caveat is that the current gesture implementation isn't compatible with modes that inherit from `DragMode`. There's probably a simple fix for that, but...

Thanks @odysseywestra! Not sure if/when I'll have time to revisit this, but some notes/updates for posterity: - I tested this in Windows, and the gesture itself works. But there's a...

Error message for the failure case makes sense, just added. :slightly_smiling_face:

Sorry for the trouble + thanks for the report; I just yanked `tyro==0.3.34` from PyPI. Still working on reproducing and won't re-release until it's fixed.

Yeah, the error implies we're getting 0 from `current_depth_pixels = outputs["depth"].shape[0] * outputs["depth"].shape[1]`. Probably there's an edge case in `_calculate_image_res`, or how client camera aspect ratios are read/used?

The specific runtime error you're seeing does look like it was fixed upstream several months ago. Are you on the latest version of the k-Planes repository? https://github.com/Giodiro/kplanes_nerfstudio/pull/13/files If that doesn't...

To me this looks like just confusing naming, where `c2w @ camera_opt_to_camera` is equivalent to `world_from_camera @ camera_from_camera_opt`, which gets us `world_from_camera_opt` / `camera_opt_to_world`. (does this make sense?) IMO this...

Does anybody have a sense for how many (public) external repositories would be impacted by this?

> I believe external repos should fix an NS version. This seems like a reasonable thing to recommend! > Do you agree to merge this as is, or should we...