Brent Pedersen

Results 878 comments of Brent Pedersen

maybe I misread your prescription. do I pass in meta without the final trailing '\0' and the appropriate l_meta?

`new_seq` does give zero'ed memory.

Hi, you are using `newRecord` it must be `NewRecord`. nim is usually not case-sensitive for variable names, but the first letter matters.

Hi, this is not how those fields work. SamField is an enum, not a property of a record. I would use: `var new_read = old_read.copy()` and then modify the fields...

You can assign to the mapping quality directly with: `new_read.b.core.qual = 60` as I haven't exposed a setter.

seems so. that was an oversight. I'm not sure how active chroma is and thought maybe it's not needed, but as long as it's a dep it should be exported.

I tried to support this but there is a bug that limits having multiple generic types in some cases, e.g.: https://github.com/nim-lang/Nim/issues/7794 You can get around this by not setting `xs`...

I think minimizing the "surface area" of the API should also be a concern given the size of the plotly api. I'm always annoyed when there are so many definitions...

I mean, for example, the ones the use ordered fields, as in: https://github.com/brentp/nim-plotly/blob/master/src/plotly/api.nim#L175