Brentley Jones
Brentley Jones
I think we can do this with a flag, preferably set per-package, with a disclaimer that the format of the labels can change between `rules_swift_package_manager` releases without us having to...
That name probably isn’t unique enough if we consider that non-**rules_swift_package_manager** targets can also set a `package_name`. It probably also needs a rspm prefix/suffix. I agree with the feature request...
I would still want a `.rspm` suffix. Just to prevent collisions more. But yeah that works.
@watt @cgrindel What's needed to land this? Ideally this would be part of 1.0.
> If I understand correctly, the main nuisance here is with the .git file also being symlinked to from the execroot, right? Yes. If minimally that wasn't symlinked, we would...
> If this breaks you, please include `--noexperimental_merged_skyframe_analysis_execution` in your blazerc to disable skymeld. Sadly I will have to include that by default for `rules_xcodeproj` if this ships this way....
@joeleba Thanks! I assume that only applies to when using Skymeld? If we don't use Skymeld, `.bazelignore` won't fix the originally reported issue?
> AFAIK the noskymeld case actually goes through all the packages and only plants symlinks for the necessary ones Sure, but the issue is when a target in the root...
Just confirmed that this is an issue for the `noskymeld` case. We had to disable Skymeld for a 7.2.0rc1 related bug and we immediately hit this issue.
I assume that only applies to local execution. Ideally we would have a way that to specify custom resource requirements and have platform executors see those when scheduling. For example,...