brentam
brentam
> LGTM! Fix spotless & friends? > > Would love to have a sample/doc for this, https://github.com/opensearch-project/opensearch-java/tree/main/samples and/or https://github.com/opensearch-project/opensearch-java/tree/main/guides. Yes. I ran the spotlessApply command and fixed the formatting. I...
> @brentam my apologies but this is not how it is already implemented in `opensearch-java`: the language specific analyzers are the combination of `org.opensearch.client.opensearch._types.analysis.LanguageAnalyzer` and `org.opensearch.client.opensearch._types.analysis.Language` enumeration @reta I believe...
@reta Some more points about the LanguageAnalyzer. I am not sure what the json generated from that builder is supposed to be... I already pointed out that the **"type" :...
@reta thank you so much for your response. So the existing DutchAnalyzer was an obsolete and should have been removed with the introduction of the LanguageAnalyzer... In Any case, I...
@reta If using the LanguageAnalyzer, the CjkAnalyzer will have to be deleted too. That analyzer was added in August of 2023. If follows the pattern of Analyzer per language, the...
@reta here is the PR with the quick changes to the Analyzer/LanguageAnalyzer [788](https://github.com/opensearch-project/opensearch-java/pull/788)
> Thanks @brentam > > > As I said, it seems to me that design using the Per Language Analyzer seems the correct way since it follows the current design,...
I wholeheartedly agree that we this feature should be prioritised. Our team has encountered a significant challenge that is nudging us towards considering alternative clients. The issue arises when the...
@reta @msfroh Sorry, I have been busy and could not visit this thread. I can revisit this thread in the near future. Atm, out team is more concerned with another...
@dblock hi, I will try to contribute when I have some time, I probably will add all the missing languages. That would be enough for this case.