opensearch-java icon indicating copy to clipboard operation
opensearch-java copied to clipboard
verified publisher icon opensearch-project

discussing changes to LanguageAnalyzer

Open brentam opened this issue 2 years ago • 4 comments

Description

This a temporary/draft PR to discuss the viability of changes to the LanguageAnalyzer needed to correct some issues. The original PR is here #779

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

brentam avatar Dec 31 '23 04:12 brentam

Let's tag @msfroh here who works on search for some 👀 . I don't understand how much of this is supposed to work, and I am looking forward to @brentam to become an expert here and help us sort this mess out!

dblock avatar Jan 03 '24 16:01 dblock

Let's tag @msfroh here who works on search for some 👀 . I don't understand how much of this is supposed to work, and I am looking forward to @brentam to become an expert here and help us sort this mess out!

Thanks! I'll need to go through this a bit.

I'm not clear on why the client needs to be aware of what analyzers exist server-side (especially since that can vary based on what plugins are installed on the server). I'm going to read through until I understand what the client is doing.

msfroh avatar Jan 04 '24 19:01 msfroh

@reta @msfroh Sorry, I have been busy and could not visit this thread. I can revisit this thread in the near future. Atm, out team is more concerned with another issue. Some of the builders not able to deserialize our query properly due to some erros in the implementation. What we need is a way to pass a raw json to the seach client. (without having to deserialize to the api java classes). I will probably create an story for this, and will be glad to work on it if you guys agree is something we should have.

brentam avatar Jan 20 '24 06:01 brentam

What we need is a way to pass a raw json to the seach client. (without having to deserialize to the api java classes). I will probably create an story for this, and will be glad to work on it if you guys agree is something we should have.

@brentam sure, please check if we already have an issue for that , fe https://github.com/opensearch-project/opensearch-java/issues/377 may be the one your are looking for

reta avatar Jan 20 '24 14:01 reta