Brent Roose

Results 287 comments of Brent Roose

Sidenote: this is a genius idea and I already don't want anything else anymore

Totally agree, this is awesome

I think the best way forward with this PR is to rebase and merge it. We can always improve on it later, but right now it's in limbo and no...

Yes, feel free to send a (tested) PR with new methods! I'm gonna close this issue as well, but go ahead!

> While less developer friendly 😱 > have you tried parsing files with nikic/php-parser at all? I'd imagine it'd be faster, but unsure Why? Compared to reflection? Noooo definitely not,...

@Wulfheart every package that has a dependency on a tempest core package is considered a tempest package. Right now you'd need to require eg. `tempest/core` and your package will be...

> Store discovery cache as plain PHP instead of manually serializing it I played around with several cache pool adapters, the fastest one is actually serializing the payload and storing...

Taking note of some benchmarks, this is `time ./tempest` | branch | cache enabled | cache disabled | partial cache enabled | | ------------- | ------------- | ------------- | -------------...

Benchmarks for running our testsuite | branch | test suite | | ------------- | ------------- | | main | 00:16 | | partial-discovery-cache | 00:15 ✅ |

TODO after merge: - [x] Document partial discovery cache - [x] Composer hook to automatically generate discovery cache - [x] Testing, but it should be done outside our normal test...