Brent Roose
Brent Roose
Interesting, thanks for clarifying! The problem here is that it doesn't really scale when you need to apply multiple middleware to multiple routes, then you'd need to repeat routes or...
> To make sure I understand your example, it is just a new interface for decorators? Yes, to optionally build on top of existing decorator functionality. > Would it simplify...
Yeah the change in #1688 turns out to be my mistake. That being said, the previous code also had an issue: it always cleaned the session even if no session...
You're right that there's a possible security risk here, although the same could be done in Laravel or Symfony, no? It's possible to register malicious routes within vendor packages in...
I believe the same is possible in both Symfony and Laravel though: a package could access the DI container, thus is can access the router, thus it can directly register...
I like the idea of some kind of audit tool in the future, but it's not really high on the priority list right now.
Looks clean! How will we handle the breaking change? Is there a way we can keep the old way for now but deprecate it? Just so that we can have...
I'm fine merging it in; but we should provide a rector for it then. Are you up for that? Otherwise I'll take care of it
I'm on the fence about it if we don't have a rector for it. Gonna ask around on Discord for some real life examples.
> causes my CPU temperature to rise by 15 degrees Do you mean with this branch?