Brent Roose comments

Results 287 comments of


                                            Brent Roose

Database seeders

I've added this to post-1.0. However if someone wants to pick it up before, feel free!

Database seeders

My suggestion: - Add a `DatabaseSeeder` interface, all implementations get discovered - For now, we don't add support for `.sql` seeder files. They are already discovered as migrations One open...

Questions and Possible Bugs

I'll look into these and fix them :)

Questions and Possible Bugs

You're welcome to send a PR, sure :) I believe the quoted strings are intentional, but I'm fine changing them to include the quotes — makes more sense to me.

Questions and Possible Bugs

This is merged now :)

function named `new` is colored as a keyword: `public static function new(mixed ...$params): self;`

Fixed: https://github.com/tempestphp/highlight/releases/tag/2.9.0

[Bug]: Interactive CLI screen isn't properly cleared when rerendered

https://github.com/tempestphp/tempest-framework/pull/576

[Bug]: Interactive CLI screen isn't properly cleared when rerendered

Not fixed: try with `cache:clear` and select two cached

Map Upload files into request properties

Are you sure this works? Because `$from->getFiles()` is an array without named keys?

Map Upload files into request properties

I think the easiest path forward is to submit a PR that I can review ;)