highlight icon indicating copy to clipboard operation
highlight copied to clipboard
verified publisher icon tempestphp

Questions and Possible Bugs

Open lemmon opened this issue 1 year ago • 4 comments

I noticed some strange behaviour. Not sure whether it's documented somewhere or not so I'm summarizing it here with few examples.

Screenshot 2024-08-04 at 11-16-03

  1. Is there any particular reason why strings are being highlighted without the quotation marks? (both Javascript and PHP)
  2. Why numbers are not being highlighted. (PHP)
  3. Numbers are not being highlighted and the decimal part is being treated as a property. (Javascript)

lemmon avatar Aug 04 '24 10:08 lemmon

I'll look into these and fix them :)

brendt avatar Aug 27 '24 12:08 brendt

Need help? I can look into it. But I was wondering if those strings without quot marks are intentional.

lemmon avatar Sep 03 '24 14:09 lemmon

You're welcome to send a PR, sure :) I believe the quoted strings are intentional, but I'm fine changing them to include the quotes — makes more sense to me.

brendt avatar Sep 04 '24 05:09 brendt

Allright. I'll try to do both PHP and JavaScript. See how that goes. Also, attaching another issue with strings:

Screenshot 2024-09-05 at 09-36-30 Test

lemmon avatar Sep 05 '24 07:09 lemmon

This is merged now :)

brendt avatar Oct 24 '24 06:10 brendt