Brendon Muir
Brendon Muir
Hi @StefSchenkelaars, meet @swelther! :) It seems you two are struggling with unique constraints! The library wasn't built with these in mind and various people have tried to fix this...
@StefSchenkelaars, funnily enough I'm the maintainer for `ranked-model` too! :D I also get tickets there for deadlocks and uniqueness constraints. We just solved a recent rebalancing uniqueness issue by blanking...
Hi @StefSchenkelaars, this is great work! The issues area for this gem have gone mental over the Easter weekend! Still catching up :) I guess people have a lot of...
That's what I was meaning around transactions. I worry that users might explicitly start a new transaction in their callbacks and then I wonder what happens to our transaction? From...
Hi @tjwallace, you raise a good point. I like the optimisation. Perhaps just as a courtesy, contact the person who introduced this feature and see if they're using `sequential_updates`? That'll...
Thanks @zharikovpro. Indeed @tjwallace, we should probably have a test for this. I think it's an ok change, but we'll have to bump a minor version to signal the change....
I'm still interested in adding this. Also see https://github.com/swanandp/acts_as_list/pull/284/files which I've closed but had a test for detecting corrupted lists. Perhaps we could add an auto-correct option (off by default)?
I'm happy to review what you guys come up with. I think the overarching goal of any auto-correction would be for it to be completely transparent to the user (and...
Hi @DanielHeath, thanks for this one. There are a lot of test failures in the CI suite. Would you be able to look into those when you get some time....
Hi @DanielHeath, thank you so much for your work on this. I'm returning to work next week and endeavour to go through all my waiting PR's etc... I'll get back...