Brendon Muir

Results 402 comments of Brendon Muir
trafficstars

Good hints there :) Closing due to age.

Hey, can this be merged in, and a new gem released please? If you don't have time, just add me as a collaborator on the repo and I'll do it...

I ended up not using `table_builder` anymore. Using `full_calendar` instead. Was a bit of a mission to change out but it worked well in the end. It might pay to...

Thanks @xiaocang :) That's all good. I was just letting you know in case it was an oversight as I think people would probably expect the default logs to be...

It seems to be related to assumptions around method names. Pretty tricky :D https://github.com/janko/image_processing/blob/c20d147765a064840d4cad0ff6b7ebcfe65eeaa8/lib/image_processing/processor.rb#L9 My method requires knowing the dimensions of the image, so it needs to be loaded. Changing...

I've gone with renaming the method to `cover` and have added the method for MiniMagick also (along with tests and a CHANGELOG). I don't see anywhere for documentation other than...

Hi @janko, just wondering if you needed me to do anything else to this PR? I'm happy to discuss the reasons behind it if it's not making sense :)

Hi @janko, just following this up again. Do you have any feedback on the PR? Happy to change what needs changing.

No worries at all. I've just pushed that change now.