Brendan Dahl

Results 100 comments of Brendan Dahl

I'm not familiar with karma-runner, but is there a way to capture the startup output of Firefox in the docker image? That would probably tells us where it's crashing. Alternatively,...

It doesn't look like that is capturing all of stdout/stderr from Firefox. There should hopefully be a message `You are running in headless mode`. I suppose it's possible it's crashing...

Would someone be able to try a [debug build of Firefox](https://queue.taskcluster.net/v1/task/de2Xf_TYQ-mELW4dwWX67A/runs/0/artifacts/public/build/target.tar.bz2)?

Looks like the failure comes from https://github.com/mozilla/gecko-dev/blob/a8add2ef97e68e80eef21fa8bc78951207ed5883/dom/bindings/BindingUtils.h#L206 still looking at ways around it.

Yeah, I'll take a look in a bit. Fixing a bug on spidernode atm.

Hacky way to do this: https://github.com/brendandahl/positron/commit/78db7db098571898bc4d5fbc06420e3e577b72d7

Gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=1276363

Upstream bug with fix using @jryans suggestions of checking ItemType https://bugzilla.mozilla.org/show_bug.cgi?id=1277102

Another thought is startup time. I've seen a few people gripe about electron's startup time.

As discussed in IRC, setDestructor has been removed from electron https://github.com/electron/electron/commit/06cf0406fe8ddcef3a500a689952c77fdfb9c9a8#diff-695530a8eced1fbb2c784d6a52a4290f Though we'll likely need to support setRemoteCallbackFreer and setRemoteObjectFreer