Brett Caswell

Source Review: Try Pattern implementation is not in line with convention or expectation

2

https://github.com/tmds/build-image/blob/0f398a6b36362f4d295931d046dbdb2f1dbab1e6/src/build-image/ContainerEngine.cs#L40 We should be returning an integral value (`bool` or `int`) and using `out` param on the method. Edit: I referenced link to the incorrect line.

typo handling to addresse code quality related issue #16 resolves #16

minor typo handling for code quality ## Definition https://github.com/tmds/build-image/blob/0f398a6b36362f4d295931d046dbdb2f1dbab1e6/src/build-image/ContainerEngine.cs#L85 ## Which will impact lines like: https://github.com/tmds/build-image/blob/0f398a6b36362f4d295931d046dbdb2f1dbab1e6/src/build-image/ContainerEngine.cs#L75 https://github.com/tmds/build-image/blob/0f398a6b36362f4d295931d046dbdb2f1dbab1e6/src/build-image/ContainerEngine.cs#L82

Tar methods wrongly use the term "ASCII" for non-encoded string bytes

3

https://github.com/icsharpcode/SharpZipLib/blob/fec479c2e1a2c7cd58ba8319450901fe40eb070f/src/ICSharpCode.SharpZipLib/Tar/TarHeader.cs#L1088 ### Steps to reproduce 1. see https://dotnetfiddle.net/lATEXU ```cs public static void Main() { var s1_UTF_16 = "ABC网络D"; var b1_UTF_16 = Encoding.Unicode.GetBytes(s1_UTF_16); var buffer_UTF_16_default = new byte[b1_UTF_16.Length]; var buffer_UTF_16_ASCII =...

relates to issue\bug #7 - Adds `GetSByte` and `GetSBytes` methods to `ArkArchive` - Modify `GetByte` and `GetBytes` to return `byte` and `byte[]` in `ArkArchive` - Handle usages of `GetByte` based...