Brett Caswell

Results 12 comments of Brett Caswell

we can also refactor the method implementation at bit there as well, - quite a few of those operations (collection instance of `ProcessStartInfo`) aren't caller instance dependent (since they are...

an interesting feature. Are we open to adding dependencies? if so, what sort of SLA or Licensing is acceptable?

I'm going to relate this to #253 - 'Customizing the visual appearance' and - 'premium theming' ...are aspects of Professional subscription and services. As such, I think contributors should be...

right, the merit to the expectation is the references to 'ASCII only' and 'non-ASCII' throughout the codebase (including the obsolete attribute message on several constructors of types it seems), as...

It depends, does Xamarin.Android use v4.0 .NET Runtime? Note that this is an MSBuild project for ILMerge (it extends it actually) - it doesn't add support for runtime platforms that...

@flagoss can you review this PR that mentions this issue (I could not reference you directly as a request reviewer) Though I can see in your commit that you referenced...

you should consider using ILMerge.MSBuild.Task as it handles the search in a manner that isn't hardcoded

hmm... the path should be using `ProgramData`, not `Program Files`. `ProgramData` is a hidden directory. ![Screenshot of Hidden ProgramData Folder](https://user-images.githubusercontent.com/967010/75728351-1d5db700-5cad-11ea-9e2b-bd4a7eaa887a.png) The files that are being **zapped** are specifically at `C:\ProgramData\Docker\windowsfilter\`...

How did you get around TrustedInstaller owning some directories and files in subdirectories of `windowsfilter` layer folders that cause Access Denied issues when attempting these steps? or did you not...

I heard (and it makes sense) that you can switch to the Linux containers, run the tool, than switch back to Windows Containers. It also may help in some cleanup...