Martynas Pumputis

Results 164 comments of Martynas Pumputis

Maybe there is a nice way to get the `--cni-bin-dir` value w/o reading `/proc/$KUBELET/cmdline`? Asking, as otherwise `weave setup-cni` would depend on kubelet being up and running.

@ksankeerth I think listing DaemonSets in the `kube-system` ns, and then matching for `kube-proxy` should work on > 80% clusters. So yeah, I suggest to take this approach. Another problem...

@ksankeerth Hey, one user has reported that on a k3s installation there is no kube-proxy pod. Perhaps we should detect when cilium-cli is running against a k3s cluster, and then...

@ksankeerth One more thing which needs to be fixed is opting out from the KPR auto-detection if user sets the KPR flag (via `--helm-set` or `--kube-proxy-replacement`).

@ksankeerth :wave: > We can use annotations of the K3s server/node to detect k3s and opt-out from the KPR auto replacement. :+1: > But regarding the 2nd requirement, I think...

@ncopa You can use the client and the server from https://github.com/brb/conntrack-race to reproduce the issue w/o k8s.

@javu7762 Could you rebase against the master (`git fetch -u origin && git rebase origin/master`) instead of merging it into your branch?

/test-1.25-net-next Job 'Cilium-PR-K8s-1.25-kernel-net-next' failed: Click to show. ### Test Name ```test-name K8sDatapathConfig Check BPF masquerading with ip-masq-agent DirectRouting ``` ### Failure Output ```failure-output FAIL: Failed to add ip route ```...

> Is there anything to do by me for merging? @javu7762 There is a conflict in ` pkg/service/service_test.go`. Also, we need to get ACK from @aditighag.