Martynas Pumputis

Results 164 comments of Martynas Pumputis

> After my testing, the configMap mounted by the agent pod does not changed, so we should use patch here, but I'm not sure which namespace the configMap is created...

@cyclinder Thanks. Could you rebase your code against the latest Cilium's master. It should fix some GH action failures. Once it's done, I will rerun the CI.

@ArthurChiao Thanks for the CFP. I think you can achieve this today with https://kubernetes.io/docs/reference/labels-annotations-taints/#servicekubernetesioservice-proxy-name and Cilium's flag `--k8s-service-proxy-name`. By setting different values, Cilium would hand off service provisioning (and thus,...

> Does the current behavior of Cilium is a faithful implementation of Kubernetes standard, or a custom optimization? It's a faithful implementation of what kube-proxy does + custom optimizations which...

Good find! We do have tests which check whether no traffic was disrupted during the upgrade - https://github.com/cilium/cilium/blob/master/test/k8s/updates.go#L318. I wonder why it didn't catch the issue.

@borkmann Please check whether the logic is correct for the NAT46x64 services.

Blocked by https://github.com/cilium/cilium/pull/20648.

/test Job 'Cilium-PR-K8s-1.16-kernel-4.9' failed: Click to show. ### Test Name ```test-name K8sConformance Portmap Chaining Check connectivity-check compliance with portmap chaining ``` ### Failure Output ```failure-output FAIL: Failed to retrieve DNS...