Martynas Pumputis

Results 164 comments of Martynas Pumputis

@ysksuzuki Sure! Do you plan to fix the issue, or just disable the BPF host routing when the veth chaining is used?

> Do you think we should leave a chance for generic-veth users to take advantage of the BPF host routing or just fall back to the legacy host routing? cc...

Considering https://github.com/cilium/cilium/pull/20425, this PR might be not needed. Moving to draft for now.

I'd suggest to wait with this PR until https://github.com/cilium/cilium/pull/19712 has been merged. Marking as draft for now.

Fixed by https://github.com/cilium/cilium/pull/21337.

Took another stab (cc @squeed): ``` time="2022-09-21T13:30:55Z" level=debug msg="running command: kubectl -n 202209211330k8sdatapathconfigcheckbpfmasqueradingwithip-masq-ag get pods -l zgroup=testDSClient -o jsonpath='{range .items[*]}{@.metadata.name}{\"=\"}{@.status.podIP}{\"\\n\"}{end}'" cmd: "kubectl -n 202209211330k8sdatapathconfigcheckbpfmasqueradingwithip-masq-ag get pods -l zgroup=testDSClient -o jsonpath='{range...

Thanks @slayer321. Forgot to add `-i` when grepping. The new list: ``` k8s/custom_calls.go: podApp1.Status.PodIP, identityKey, IngressIPv4, k8s/custom_calls.go: podApp1.Status.PodIP, identityKey, EgressIPv4, k8s/datapath_configuration.go: srcPodIP, err := srcPodJSON.Filter("{.status.podIP}") k8s/datapath_configuration.go: dstPodIP, err := dstPodJSON.Filter("{.status.podIP}")...

@slayer321 Please hold on with a fix. It might be a case that everything is fine with `PodIP` - https://github.com/cilium/cilium/issues/21120#issuecomment-1253865738.

@slayer321 It's no longer an issue. Sorry for forgetting to update the issue.

Out of curiosity, wouldn't adding a "layer" of promises introduce possibilities for deadlocks during startup?