Brandon Payton

Results 304 comments of Brandon Payton

If we want to get rid of the cookie store, it may be necessary to do something like: Message a server client tab and ask it to set cookies before...

Because we cannot directly relay `Set-Cookie` headers via custom Response objects (they are [forbidden response headers](https://fetch.spec.whatwg.org/#forbidden-response-header-name)), I think we still need the HttpCookieStore for `php-wasm/web`, but we should be able...

> I think a good solution may be to support filter callbacks for requests and responses within PHPRequestHandler so the bulk of the logic can be maintained in php-wasm/universal while...

> On second thought, we should just be able to handle this in the service worker with a per-scope cookie store. AFAICT, this would require no API changes. I am...

It looks like [`convertFetchEventToPHPRequest()`](https://github.com/WordPress/wordpress-playground/blob/ac36cbebdbc8a776578504b7a06b91d104b2fc2d/packages/php-wasm/web-service-worker/src/utils.ts#L7) in the `@php-wasm/web-service-worker` package may be a good place to for this. It is specific to running in web browsers, where we are forbidden from accessing...

> 1. Where to best coordinate setting a playground-fetch-includes-cookies=1 cookie to serve as a hint whether cookies should be relayed with a given fetch request. Scratch that. We should just...

> UX idea: display select boxes for path selection, not inputs. Options: Nice. This would reduce the opportunity for typos, and selection sounds less stressful to me than having to...

@juanmaguitar Sure thing. Done!

@adamziel I am currently trying to work through this. Initially, I was going to create a PR to quickly communicate my thoughts but kept finding edge cases. What is difficult...

> I think it is probably OK in most cases to treat files without an extension (i.e., without a "." in them) as directories. That is probably a reasonable first...