Brandon Payton

This is failing cppcheck. Will take a look and fix.

Actually, the warning appears to be unrelated to this patch: > warning: [src/utils/shared_files.h,88](https://github.com/SpiderLabs/ModSecurity/blob/7e0bc2691727b8c75f74638cdc4d1c45a689a7b6/src/utils/shared_files.h#L79-L87),performance,useInitializationList,When an object of a class is created, the constructors of all member variables are called consecutively in...

Sorry, I was incorrect. The previous warning is the only warning I'm seeing on my dev machine. There is a relevant warning from TravisCI running `make check-static`: > warning: src/utils/shared_files.h,60,style,functionConst,The...

I added the above warning to the cppcheck suppressions list because `SharedFiles::reopen()` does change SharedFiles internal state.

Regarding thread-safety: I was reading the nginx source this evening and noticed it redirects stderr using a POSIX function, `dup2`. `dup2` takes an old and a new descriptor and atomically...

Hi @martinhsv, thank you for your feedback on this PR. I'm happy to hear you are open to changes of this nature. > There is, in principal, an intention to...

> IMO, it's better to use atomic group or possessive quantifiers for regex rules. Hi @liudongmiao, do you mean that it would be better if rule authors wrote better, safer...

Hello @martinhsv, Would you like me to make any changes to this PR? Is there anything I can do to help this PR or something like it to land? My...

It makes sense this one is failing CI because the changes it relies on aren't yet in ModSecurity.

In the case of this patch, viewing with ignoring whitespace changes emphasizes the simplicity of this change: https://github.com/SpiderLabs/ModSecurity-nginx/pull/271/files?w=1 On another note, I just realized that [nginx checks r->request_body->bufs for NULL](https://github.com/nginx/nginx/blob/828fb94e1dbe1c433edd39147ba085c4622c99ed/src/http/ngx_http_variables.c#L2060)...